elephant-bird icon indicating copy to clipboard operation
elephant-bird copied to clipboard

Version requirements documentation for Protocol Buffers requires updates?

Open kendaleiv opened this issue 11 years ago • 2 comments

https://github.com/kevinweil/elephant-bird#version-compatibility: "Protocol Buffers 2.3.0, 2.4.1"

https://github.com/kevinweil/elephant-bird#protocol-buffer-and-thrift-compiler-dependencies "Elephant Bird requires Protocol Buffer compiler version 2.3 at build time, as generated classes are used internally."

It seems to require 2.4.1 when I invoke mvn package:

[INFO] Protobuf dependency version 2.4.1
[INFO] 'protoc' executable version 2.3.0

kendaleiv avatar Apr 30 '13 01:04 kendaleiv

The whole dependency management in EB is a bit of a mess. EB compiles and works fine with both protobuf versions. We should make build time version configurable with a mvn flag (or just derive based on 'protoc' binary).

rangadi avatar Apr 30 '13 02:04 rangadi

pull #308 supports 'protobuf.version' variables and it can be set to 2.3.0 (not sure if hadoop2 profile may not work with it. But hadoop1 profile does work).

rangadi avatar May 05 '13 19:05 rangadi