chill icon indicating copy to clipboard operation
chill copied to clipboard

[FOLLOWUP][PR514] Update to use the newer Kryo 5.5.0

Open roczei opened this issue 1 year ago • 10 comments

Hi Chill team,

This is a follow up on this PR: https://github.com/twitter/chill/pull/514

Main changes:

  • Rebased the PR514 to the latest develop state
  • Fixed all unit test issues
  • Set Kryo 5.5.0 version which includes the fix for "Serialization of a generic array of enum" (this fixed the TestVarArgs case class issue in KryoSpec.scala)
  • Switched to versionless kryo5 package (this fixed all mimaReport issues). If you think this is not the right solution and we have to use the versioned imports, I can drop the last three commits
  • Added back the chill-storm module

I have already tested with sbt test and all tests passed.

roczei avatar Apr 24 '23 11:04 roczei

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 24 '23 11:04 CLAassistant

FYI: @nicknezis, @johnynek, @regadas

roczei avatar Apr 24 '23 12:04 roczei

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 :tada:

Comparison is base (f69dfa0) 91.85% compared to head (8c1bf86) 91.87%.

:exclamation: Current head 8c1bf86 differs from pull request most recent head e657107. Consider uploading reports for the commit e657107 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #747      +/-   ##
===========================================
+ Coverage    91.85%   91.87%   +0.01%     
===========================================
  Files           46       46              
  Lines         1425     1427       +2     
  Branches        28       35       +7     
===========================================
+ Hits          1309     1311       +2     
  Misses         116      116              
Impacted Files Coverage Δ
...la/com/twitter/chill/akka/ActorRefSerializer.scala 100.00% <ø> (ø)
...m/twitter/chill/algebird/AlgebirdSerializers.scala 100.00% <ø> (ø)
...cala/com/twitter/chill/BijectionEnrichedKryo.scala 53.33% <ø> (ø)
.../scala/com/twitter/chill/InjectiveSerializer.scala 100.00% <ø> (ø)
...2-/com/twitter/chill/ClassManifestSerializer.scala 0.00% <ø> (ø)
...in/scala-2.12-/com/twitter/chill/Traversable.scala 100.00% <ø> (ø)
...12-/com/twitter/chill/WrappedArraySerializer.scala 100.00% <ø> (ø)
...scala/com/twitter/chill/BigDecimalSerializer.scala 100.00% <ø> (ø)
...ain/scala/com/twitter/chill/BitSetSerializer.scala 100.00% <ø> (ø)
...n/scala/com/twitter/chill/ClassTagSerializer.scala 0.00% <ø> (ø)
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Apr 24 '23 16:04 codecov-commenter

I have sent this mail to the chill-user list regarding this pull request:

https://groups.google.com/g/chill-user/c/t5y8xBEjTXY

Hi Chill maintainers / users,

Is this twitter/chill project still active? The latest chill version depends on 4.0.2. Are there any chance for a new chill release which can include the following pull request?

[FOLLOWUP][PR514] Update to use the newer Kryo 5.5.0: https://github.com/twitter/chill/pull/747

We would like to migrate Apache Spark and Apache Livy to Kryo5 and we are blocked due to this missing pull request.

Thanks in advance for any responses!

roczei avatar May 10 '23 18:05 roczei

Hey! Things have been a bit busy on my side, but I'll see if I can pick up things here in the coming days.

Thanks for the poke and PR. 🙏

regadas avatar May 10 '23 19:05 regadas

Thanks @regadas!

roczei avatar May 10 '23 19:05 roczei

Hi, I hope we can get this soon! It will be a good step forward to unify everything to Kryo 5.

alejandrod-f avatar Jul 07 '23 15:07 alejandrod-f

Hey! Things have been a bit busy on my side, but I'll see if I can pick up things here in the coming days.

Hi @regadas,

Sorry to trouble you, but did you a chance to take a look at this pull request? I wonder if you could tell me when can we expect a new chill release which include it? I really appreciate your reply in advance.

roczei avatar Jul 17 '23 07:07 roczei

Hello, is there still an intention to merge this PR?

mcmoe avatar Oct 03 '23 12:10 mcmoe

Hello ~ Is there any progress on this PR?

LuciferYang avatar Dec 19 '23 07:12 LuciferYang