algebird
algebird copied to clipboard
algebird-bufferable
This is just a start, and shouldn't be merged yet, but: defining some Bufferable implementations for Algebird objects so that we don't have to use Kryo for long-term serialized storage.
Of course any bijection module could go in either bijection or the project on which the module depends, but I wonder if this should just go into https://github.com/twitter/bijection/tree/develop/bijection-algebird? Good stuff, though, this is really great.
I think the argument for making this part of algebird rather than bijection is that its rate of change will be more closely tied to algebird's; we're more likely to add new data types to algebird that need new bufferable implementations, than we are to change how bijection/bufferable work.
Ah, sure, good point. Should we start this and think about folding bijection-algebird back in to here?
Hmm, looks like 2.10 isn't happy.
Fix the 2.10 issues and the comments and we merge (and publish in the next week or two).
Do you think we're better to just move to scala-pickling, or are you confident that Bufferable is going to be used/useful in the long term?
I assume in the long run pickling will be a win, but currently it looks like we need 2.10 and I'm not sure the Java story, which matters for us.
Can I talk you into getting this green?
I want to merge it for the next release in a week or two.
(really want one for BloomFilter too, by the way).
I'll try to find time in the next week yeah.
Boom, we're about to merge algebird-bijection... let's move these over there. I like this.
Hey @avibryant, can we get you to move these into algebird-bijection?
Hey, really sorry I haven't gotten to this yet; not sure when I'll have time. If someone else wants to take it on, great, otherwise I'll get to it when I can, but either way we shouldn't hold up a release for it obviously.
Sorry my bad, git foo on cmd line broke stuff and closed all of these
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.