When plot = FALSE, don't call plot.new

[jcpetkovich]

plot.new() is generally unfriendly to call unless it will actually be used for drawing, and certainly not if we ask for no plots to be created.

plot.new triggers the completion of the previous plotting action, and as such can't be used in combination with any multithreading or forked R processes.

plot.new also does not return a "plot" object, it always returns NULL, so although it appears to be used here as a way of returning a "null plot", all that really happens is that AnomalyDetection* returns list(..., plot = NULL).

This commit resolves #60

[jhochenbaum]

Thanks @jcpetkovich !

[akejariwal]

@caniszczyk The PR looks good. Please merge.

[jcpetkovich]

Anything holding this back from a merge?

[wlopata]

Ping! Just hit into this issue myself.

[trh178]

Also just hit the issue. Does anyone else have write access to perform the merge?

[gonzalodiaz]

+1 to this change. I was about to do the same.

[dmpe]

/cc @caniszczyk

[Winterflower]

+1 for this change - please let me know if I can help in any way to get this merged into the codebase. I'm hitting this issue when trying to run AnomalyDetectionTs in a subprocess.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}