spitball icon indicating copy to clipboard operation
spitball copied to clipboard

Adding unknown state to lockfile parser. Adding support for metadata

Open garru opened this issue 15 years ago • 5 comments

for the gemfile below "version: 1.0.6" was added as a dependency. this patch fixes it so that new gemfile types will not mess up parsing, by adding a new state "unknown"

GEM specs: activesupport (2.3.9) fauna-mysql (2.8.1.3) kgio (2.0.0) memcached (0.17.4) tbird-client (0.1.0) thrift (0.2.0) thrift_client (0.4.0) thrift

PLATFORMS ruby

DEPENDENCIES activesupport (< 3.1) fauna-mysql (= 2.8.1.3) kgio (= 2.0.0) memcached (= 0.17.4) tbird-client (= 0.1.0) thrift (= 0.2.0) thrift_client (= 0.4.0)

METADATA version: 1.0.6

garru avatar Dec 20 '10 15:12 garru

Apparently bundler 1.0.6 was pulled because this metadata block was completely broken. Older versions of bundler tried to install the gem "version" or something. 1.0.7 fixed this. I'm not sure if bundler will use the same metadata section in later versions. (Though we should pull this in if that's the case, or modified if not.)

freels avatar Dec 20 '10 18:12 freels

i don't really care about the metadata. do you want me to repatch with just the unknown state fix?

garru avatar Dec 21 '10 01:12 garru

Yeah, that sounds reasonable, though perhaps we should bail if we don't know what a section means?

freels avatar Dec 21 '10 01:12 freels

all spitball cares about are dependencies right? if they decide to add back the metadata section or maybe an even more innocuous hypothetical comments section do you want spitball to just raise something like "unknown Gemfile.lock format?"

i ran into this problem when trying to use spitball with a gemfile generated with bundler 1.0.6 and i got a "run bundle install" error. so i just want to help the next person.

garru avatar Dec 21 '10 01:12 garru

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Gary seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 18 '19 15:07 CLAassistant