commons icon indicating copy to clipboard operation
commons copied to clipboard

pants.ini is out of date

Open jwaldrop opened this issue 11 years ago • 6 comments

clone the repo, attempt to run basic commands:

./pants goal list 2014-03-03 17:01:13,848 pants:57 - Required pants.ini key DEFAULT.pants_version is not present. Please add the option and try again.

adding a version reveals more missing, with no sense of just how much will need to be added. (DEFAULT.pants_pex_baseurl was the next thing.)

jwaldrop avatar Mar 04 '14 01:03 jwaldrop

Thanks for reporting. This is known broken, currently you need to:

./build-support/python/clan.sh && ./pants.bootstrap

but this is definitely a bug.

jsirois avatar Mar 04 '14 04:03 jsirois

Is this a bug? "pants" being a launcher for the pre-build pex is the expected behavior. I'm happy to revisit this but this works the way I intended it to.

I believe the "fix" is moving pants to the pantsbuild repo, making a release, and updating pants.ini to use the pre-built pants.pex.

traviscrawford avatar Mar 04 '14 17:03 traviscrawford

Is this a bug?

The documented way to invoke pants doesn't work (we don't mention "For now, you gotta run ./pants.bootstrap the first time"), so there's a bug in there. And it makes sense that folks will go looking in pants.ini, since the error message points there.

lahosken avatar Mar 05 '14 01:03 lahosken

I just spent ~30minutes trying to boostrap my commons repo, and feel like I lucked out by finding this thread. If I didn't actually want to work w/pants vs. just a "build-tool" I'd have given up long ago.

In the (presumably) short-term, can we just auto-run

 ./build-support/python/clean.sh && ./pants.bootstrap

if we detect a failure via missing .ini value?

Yasumoto avatar Mar 09 '14 22:03 Yasumoto

Oy veh--Yeah so far, we only mention the ./pants.bootstrap workaround in the pants docs; we don't mention it in the twitter/commons README. If folks will have to keep on bootstrapping for a couple of whiles, we should doc it, perhaps a la

https://rbcommons.com/s/twitter/r/96/

If we're pretty darned close to a pex for ./pants to automagically download, then nevermind :-)

lahosken avatar Mar 12 '14 15:03 lahosken

Take a look at https://rbcommons.com/s/twitter/r/95/ - that review updates commons to use a pip-installed pants rather than building from sources. When we move pants --> pantsbuild this will be the only option.

traviscrawford avatar Mar 12 '14 16:03 traviscrawford