twirp-ruby icon indicating copy to clipboard operation
twirp-ruby copied to clipboard

Additional Improvements & Options with CodeGen + Dropping Ruby 1.9

Open OmriSama opened this issue 4 years ago • 3 comments

Hi. I'm not sure if the Twitch team still maintains this package, but I wanted to suggest (and potentially help) with a couple of changes to the Code Generator plugin.

  • There should be an options to generate only Services, or Clients (not both)
  • There should be options for Module/class naming
  • There should be options for the relative filenames that Twirp expects (from protoc --ruby_out)

Let me know if any of this is planned!

Thanks in advance

EDIT: I was also wondering if there are any plans to drop Ruby 1.9.

OmriSama avatar Aug 09 '21 14:08 OmriSama

I wish to have zeitwerk support of generated files for ruby clients by default or to have better instructions if its presented already, — rails 7 going to be released soon

Mayurifag avatar Dec 07 '21 20:12 Mayurifag

@OmriSama I think it might be interesting. Do you have time to do a PR suggestion with your changes?

arthurnn avatar Mar 22 '22 15:03 arthurnn

Came here to see what was being done around Zeitwerk as well!

phantomwhale avatar May 02 '23 04:05 phantomwhale