twirp-ruby icon indicating copy to clipboard operation
twirp-ruby copied to clipboard

Please publish the 1.11.0 version to Rubygems

Open fidalgo opened this issue 1 year ago • 6 comments

The latest version, 1.11.0 is not published on rubygems: https://rubygems.org/gems/twirp/versions/

Can you please upload it?

fidalgo avatar May 17 '24 11:05 fidalgo

I don't think there is a v1.11.0 version of the gem. The release notes at https://github.com/arthurnn/twirp-ruby/releases/tag/v1.11.0 indicate:

This is a Go only release, as starting on this version the ruby and Go releases will be separate and not follow the same versioning any longer.

darronschall avatar May 17 '24 18:05 darronschall

@darronschall You're right, I was misled by the tags: https://github.com/arthurnn/twirp-ruby/blob/v1.10.0/twirp.gemspec https://github.com/arthurnn/twirp-ruby/blob/v1.11.0/twirp.gemspec

So my request would be to release the version v1.11.0, as the current v1.10.0 is not usable at all, because there's a missing rack dependency.

This is the fix we need: https://github.com/arthurnn/twirp-ruby/blob/v1.11.0/twirp.gemspec#L24C1-L24C71

Would it be possible to release a new version, to cover it?

fidalgo avatar May 18 '24 08:05 fidalgo

@darronschall Here is the commit that fixed the problem: https://github.com/arthurnn/twirp-ruby/commit/aa4000f8ea9ff84447060ab8a7f425ed70e0bf56

There's also another use complaining about the same problem and asking for a release that would include that commit.

fidalgo avatar Jun 12 '24 14:06 fidalgo

@fidalgo Unfortunately, I can't help you further as I'm not a maintainer of this gem (see #114).

You can set up your Gemfile to use the main branch, though, instead of waiting for a new release:

gem "twirp", github: "arthurnn/twirp-ruby"

darronschall avatar Jun 12 '24 15:06 darronschall

Thank you for your reply, unfortunately this is a dependency of a gem, so I cannot use that github syntax. I will for now stick the version to the previous working version and maybe this will catch @arthurnn 's attention.

fidalgo avatar Jun 12 '24 16:06 fidalgo

Would also be great if we could get thegoogle-protobuf dependency bumped/relaxed as well

https://github.com/arthurnn/twirp-ruby/blob/v1.11.0/twirp.gemspec#L22

google-protobuf v3.25 has a bug that prevents it from building properly on certain linux distros. The gem then jumps from 3.25 directly to 4.26, but the current dependency specifier in the gemspec prevents us from upgrading.

chrisbloom7 avatar Jun 26 '24 03:06 chrisbloom7

Would also be great if we could get thegoogle-protobuf dependency bumped/relaxed as well

done: https://github.com/arthurnn/twirp-ruby/pull/122

arthurnn avatar Aug 26 '24 20:08 arthurnn

https://rubygems.org/gems/twirp/versions/1.12.0 release with latest.

see here why 1.11.0 was not release to rubygems.

arthurnn avatar Aug 26 '24 21:08 arthurnn