twitch-cli icon indicating copy to clipboard operation
twitch-cli copied to clipboard

fix: set `Twitch-Eventsub-Subscription-Type` to correct type

Open Nerixyz opened this issue 3 years ago • 0 comments

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Problem/Feature

Fixes #163.

Description of Changes:

  • Remove the call to GetTopic since at that point, we alredy have the event type.

Checklist

  • [x] My code follows the Contribution Guide
  • [x] I have self-reviewed the changes being requested
  • [x] I have made comments on pieces of code that may be difficult to understand for other editors
  • [x] I have updated the documentation (if applicable)

Nerixyz avatar Jul 26 '22 10:07 Nerixyz

I just found that retrigger didn't always use the correct event (it sometimes errored with Error refiring event: Invalid event).

I think retrigger should print the response body as well, though this should be done in another PR.

Nerixyz avatar Aug 11 '22 09:08 Nerixyz

I just found that retrigger didn't always use the correct event (it sometimes errored with Error refiring event: Invalid event).

I think retrigger should print the response body as well, though this should be done in another PR.

Can you elaborate on this? Not sure if this was broken at some point in the past or with this PR.

lleadbet avatar Aug 14 '22 17:08 lleadbet

Can you elaborate on this? Not sure if this was broken at some point in the past or with this PR.

I did

twitch event trigger channel.channel_points_custom_reward_redemption.add -F http://localhost:8080/eventsub -s <secret>

then with the event-id:

twitch event retrigger -F http://localhost:8080/eventsub -s <secret> -i <event-id>

which resulted in Error refiring event: Invalid event (maybe I'm doing something wrong though).

Nerixyz avatar Aug 14 '22 19:08 Nerixyz