klein icon indicating copy to clipboard operation
klein copied to clipboard

Fix the type hint for `Field.converter`

Open rouge8 opened this issue 2 years ago • 1 comments

Field.converter is called in Field.validateValue() on the result of Field.extractValue(), which will return either a string, JSON-serializable objects, or None, but not bytes.

rouge8 avatar Dec 20 '23 21:12 rouge8

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.07%. Comparing base (bad4cf3) to head (df757be).

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk     #708   +/-   ##
=======================================
  Coverage   99.07%   99.07%           
=======================================
  Files          46       46           
  Lines        3986     3986           
  Branches      531      531           
=======================================
  Hits         3949     3949           
  Misses         23       23           
  Partials       14       14           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 20 '23 21:12 codecov[bot]