klein icon indicating copy to clipboard operation
klein copied to clipboard

Remove Deferred cancellation on client reset

Open KentShikama opened this issue 2 years ago • 1 comments

See https://github.com/twisted/klein/issues/546.

We have been running a similar patch on our enterprise production systems for about 6 months with no issues, and critically we have stopped getting issues on client resets.

KentShikama avatar Aug 16 '22 19:08 KentShikama

without automated tests is hard to know if this works or not. It might work for your case, but might introduce error to others...

I am not using klein, so I don't know.

It was just a general comment

Also, I am not sure why the CI was not triggered for this PR.

adiroiban avatar Sep 23 '22 09:09 adiroiban

I'm also not sure what's going on with CI; sorry that it's broken. Can you reword / force-push or push another commit to see if it's just a flake on github's side?

glyph avatar Oct 03 '22 20:10 glyph

I'm going to close until discussion at https://github.com/twisted/klein/issues/546 is resolved.

KentShikama avatar Dec 06 '22 05:12 KentShikama