Tim Wilson

Thanks @simontheflutist. Oops forgot to close this. This too will be superseded by #29659.

Closed this in favor of #29659 which is now closed. Reopening

I'll get Shanes's proposed changes done and a new test route so that this can be merged

I think your version is cleaner and more readable (as usual...), and that will capture 95% of what's going on (though I still plan on doing a NN for long...

I can provide test routes this week with a comparison against stock as above.

Finally got around to testing. Recorded two routes, one on master and one on this branch. * master: c11fcb510a549332|2023-07-15--18-28-15--0 * gm-volt-long-tune: c11fcb510a549332|2023-07-15--19-39-52--1 ----- Here are some plots comparing the stopping...

True, but there's consistent error on the left plot that's vanishingly small on the right plot (space between desired and actual speed, also see the magnitude on the p response....

Closed this in favor of https://github.com/commaai/openpilot/pull/29659 which is now closed. Please reopen @adeebshihadeh

I'll update this shortly Routes using a simplified EV lookup table, slightly adjusted to account for the overshoot you pointed out above.

@MoreTore The process Comma is using could be applied to any car. It's missing the speed dependence but is still hypothetically general. Have you tried using their function to fit...