twilio-video-app-react icon indicating copy to clipboard operation
twilio-video-app-react copied to clipboard

Add caption renderer

Open timmydoza opened this issue 2 years ago • 2 comments

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • [x] I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR adds a CaptionsRenderer to the video app. This can be enabled by clicking on the Show Captions button in the More menu:

image

With this enabled, captions will be rendered on the screen.

Burndown

Before review

  • [ ] Updated CHANGELOG.md if necessary
  • [ ] Added unit tests if necessary
  • [ ] Updated affected documentation
  • [ ] Verified locally with npm test
  • [ ] Manually sanity tested running locally
  • [ ] Included screenshot as PR comment (if needed)
  • [ ] Ready for review

Before merge

  • [ ] Got one or more +1s
  • [ ] Re-tested if necessary

timmydoza avatar May 03 '22 22:05 timmydoza

can this get merged?

Geczy avatar Jul 09 '22 17:07 Geczy

I tried this code, but it doesn't work ? Do we need a new api key for transcription ?

lovedota avatar Nov 20 '22 04:11 lovedota