twilio-python icon indicating copy to clipboard operation
twilio-python copied to clipboard

chore: use new unittest.mock from standard library

Open a-detiste opened this issue 11 months ago • 4 comments

https://github.com/testing-cabal/mock

"mock is now part of the Python standard library, available as unittest.mock in Python 3.3 onwards."

Checklist

  • [x] I acknowledge that all my contributions will be made under the project's license
  • [x] I have made a material change to the repo (functionality, testing, spelling, grammar)
  • [ x I have read the Contribution Guidelines and my PR follows them
  • [ ] I have titled the PR appropriately
  • [x] I have updated my branch with the main branch
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added the necessary documentation about the functionality in the appropriate .md file
  • [ ] I have added inline documentation to the code I modified

a-detiste avatar Mar 21 '24 20:03 a-detiste

I see some error here, can you check this?

tiwarishubham635 avatar Apr 04 '24 17:04 tiwarishubham635

Please merge https://github.com/twilio/twilio-python/pull/783 first and I will rebase if this can't be done automagicaly with github

a-detiste avatar Apr 04 '24 19:04 a-detiste

So finally no #783 , I will trim this down

a-detiste avatar May 02 '24 06:05 a-detiste

So there will be some changes in this repo and some in generator repo. We can use #783 for this repo's changes.

tiwarishubham635 avatar May 02 '24 06:05 tiwarishubham635

@a-detiste do you want to continue working on it?

tiwarishubham635 avatar May 22 '24 17:05 tiwarishubham635

Yes I can

a-detiste avatar May 22 '24 18:05 a-detiste

Well it's done for me... only merge needed

a-detiste avatar May 22 '24 18:05 a-detiste

Please check the failing tests. if mock is part of python since 3.3 then it should work fine with 3.7 as well

tiwarishubham635 avatar May 23 '24 05:05 tiwarishubham635