twilio-node icon indicating copy to clipboard operation
twilio-node copied to clipboard

Wrong typing for playbackGrant (PlaybackGrantContext)

Open twixr opened this issue 3 years ago • 2 comments

Issue Summary

image Full code line: image

According to the docs: (https://www.twilio.com/blog/build-livestreaming-application-twilio-live-express) image

So I looked into the code: (https://github.com/twilio/twilio-node/blob/main/lib/rest/media/v1/playerStreamer.js#L567) And it seems like the playback does not have any arguments. Yet, the type declaration file says that sid (string) is required: https://github.com/twilio/twilio-node/blob/main/lib/rest/media/v1/playerStreamer/playbackGrant.d.ts#L36

I might be wrong, but it seems like that sid argument shouldn't be there.

Tried to make a PR for it, but it is a generated file, hence the issue. :(

Technical details:

  • twilio-node version: latest
  • node version:

twixr avatar Nov 24 '21 17:11 twixr

This issue has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog.

JenniferMah avatar Dec 01 '21 22:12 JenniferMah

I tried to make a PR, however the docs are telling me that it's a part of the code where no PR's will be accepted and we have to make an issue instead.

twixr avatar Dec 13 '21 17:12 twixr

Fixed by https://github.com/twilio/twilio-node/pull/814

This will be included in the first release candidate for twilio-node@v4 dropping this week.

childish-sambino avatar Nov 28 '22 18:11 childish-sambino