twilio-java icon indicating copy to clipboard operation
twilio-java copied to clipboard

fix: RequestValidator to use getRawPath, getRawQuery() and getRawFragment()

Open bhaskar16 opened this issue 1 year ago • 1 comments

Fixes #601

Closes #601

This PR changes the RequestValidator's updatePort() method to use the raw implementations for Path, Query and Fragment which helps in better sanitisation of urls.

Checklist

  • [x] I acknowledge that all my contributions will be made under the project's license
  • [x] I have made a material change to the repo (functionality, testing, spelling, grammar)
  • [x] I have read the Contribution Guidelines and my PR follows them
  • [x] I have titled the PR appropriately
  • [x] I have updated my branch with the main branch
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] I have added the necessary documentation about the functionality in the appropriate .md file
  • [x] I have added inline documentation to the code I modified

bhaskar16 avatar Nov 18 '24 13:11 bhaskar16

@Bazzooka1972 Could you tell me how to ensure that the tests run? I would like to merge this when I can.

bhaskar16 avatar Jan 23 '25 15:01 bhaskar16