twilio-csharp icon indicating copy to clipboard operation
twilio-csharp copied to clipboard

Published 20 hours ago • verified publisher icon twilio

feat: Added Cancellation Token

Open joewashear007 opened this issue 10 months ago • 2 comments

Fixes

Fixes https://github.com/twilio/twilio-csharp/issues/514 This PR added the CancellationToken to all the async endpoints and all of the pass throughs

Checklist

  • [x] I acknowledge that all my contributions will be made under the project's license
  • [x] I have made a material change to the repo (functionality, testing, spelling, grammar)
  • [x] I have read the Contribution Guidelines and my PR follows them
  • [x] I have titled the PR appropriately
  • [x] I have updated my branch with the main branch
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added the necessary documentation about the functionality in the appropriate .md file
  • [ ] I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

joewashear007 avatar Jan 13 '25 14:01 joewashear007

I think this PR is ready, though I think it need to be reworked. it touches many of the auto generated files. But I don't think I can edit the auto generator to add the CancellationToken to the Async methods

joewashear007 avatar Jan 15 '25 18:01 joewashear007

We are planning to change Orgs API RestClient. We will review this change at that time.

sbansla avatar Jan 16 '25 06:01 sbansla