twilio-csharp icon indicating copy to clipboard operation
twilio-csharp copied to clipboard

fix: handling null 'from' parameter

Open isha689 opened this issue 2 years ago • 1 comments

Fixes

Resolved Issue as part of this PR. Serialization was failing when 'from' parameter was null, so added a check to handle the null values. Solution is referenced from here

Checklist

  • [x] I acknowledge that all my contributions will be made under the project's license
  • [ ] I have made a material change to the repo (functionality, testing, spelling, grammar)
  • [ ] I have read the Contribution Guidelines and my PR follows them
  • [ ] I have titled the PR appropriately
  • [ ] I have updated my branch with the main branch
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added the necessary documentation about the functionality in the appropriate .md file
  • [ ] I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

isha689 avatar Sep 20 '22 11:09 isha689

Changes looks good to me.

sbansla avatar Sep 26 '22 11:09 sbansla