twilio-csharp
twilio-csharp copied to clipboard
fix: Added missing model definitions for statistics
Fixes
Resolves: #624
Fixes these statistics models: Twilio.Rest.Taskrouter.V1.Workspace.Worker.WorkerStatisticsResource Twilio.Rest.Taskrouter.V1.Workspace.Worker.WorkersCumulativeStatisticsResource Twilio.Rest.Taskrouter.V1.Workspace.Worker.WorkersRealTimeStatisticsResource
The prior models are missing definitions for statistical subresources that cause deserialization to return empty/null. Other statistics models are impacted by this same issue. Suggest that developers check for other statistics definitions using object instead of a strongly typed object.
Checklist
- [x] I acknowledge that all my contributions will be made under the project's license
- [x] I have made a material change to the repo (functionality, testing, spelling, grammar)
- [x] I have read the Contribution Guidelines and my PR follows them
- [x] I have titled the PR appropriately
- [x] I have updated my branch with the main branch
- [x] I have ~~added~~ ran tests that prove my fix is effective or that my feature works
- [ ] I have added the necessary documentation about the functionality in the appropriate .md file
- [ ] I have added inline documentation to the code I modified
The changes are to generated code so we'll have to make changes in the generator. We have this on our internal backlog (DI-2274)
The changes are to generated code so we'll have to make changes in the generator. We have this on our internal backlog (DI-2274)
Understood. Thank you for reviewing and the explanation. Up to you whether or not to close.