twilio-client.js icon indicating copy to clipboard operation
twilio-client.js copied to clipboard

[FEATURE] Publish code for dependency @twilio/voice-errors

Open theHilikus opened this issue 4 years ago • 4 comments

Is your feature request related to a problem? Please describe. I'm trying to create a webjar of the JS voice SDK to handle my client-side dependencies with maven but unfortunately, as it is right now, there's a declared dependency here to @twilio/voice-errors. This library is not available in github, so it can't be converted to a webjar automatically. The NPM config doesn't point to any public git repo so the package can't be generated; it mentions https://code.hq.twilio.com/client/twilio-voice-errors but that is not accessible and AFAIK, it can't be used by the webjaring tool

Describe the solution you'd like Publish the repository for voice-errors in github with a proper npm config (like the one in this project) so that the webjaring tool can convert it to a jar and it can be pulled as a dependency for twilio-client.js

theHilikus avatar Sep 30 '19 14:09 theHilikus

Thanks for the feedback @theHilikus, I think we should be okay to push that repo to public GH. I'll investigate and keep you updated.

ryan-rowland avatar Oct 29 '19 19:10 ryan-rowland

Created Jira CLIENT-7428

charliesantos avatar Mar 13 '20 17:03 charliesantos

Hi @charliesantos This was closed without a resolution. The repo is still not in github and the latest version on npm is still pointing to internal twilio git repositories

I tried again to package twilio-client 1.13.0 into a webjar today but i still can't use it because voice-errors cannot be webjared. image

I would imagine that reducing the friction of your users to adopt twilio would be a priority. Especially when it's as simple as publishing a minor library in a different git repo, as @ryan-rowland mentioned

Do you have an idea if this will ever happen?

Thank you

theHilikus avatar Jan 08 '21 23:01 theHilikus

Hi @theHilikus , Let me follow up with @ryan-rowland .

charliesantos avatar Jan 09 '21 00:01 charliesantos