ortc-adapter icon indicating copy to clipboard operation
ortc-adapter copied to clipboard

return expects an object?

Open WieserSoftware opened this issue 9 years ago • 1 comments

In ortc-adapter.js setRemoteDescription, there's a line that says return void onFailure(invalidSignalingState(this.signalingState));

Should it be onFailure(invalidSignalingState(this.signalingState)); return;

instead?

WieserSoftware avatar Jan 14 '16 08:01 WieserSoftware

@WieserSoftwareLtd this was an experiment in JavaScript style and an attempt to appease ESLint, but I agree it is a little weird to read—it may be worth rewriting in a future release.

markandrus avatar Jan 20 '16 18:01 markandrus