serverless-toolkit
serverless-toolkit copied to clipboard
feat(twilio-run): upgrading serverless-runtime-types
- Upgraded
serverless-runtime-types
in thetwilio-run
package - Fixed typing errors that arose from using the new version
- Added cookies attribute to
Response
class, as well assetCookie
andremoveCookie
functions in order to fully implement theTwilioResponse
interface - in the
constructContext
function of routes.ts, I had to explicitly include theSERVICE_SID
andENVIRONMENT_SID
attributes ofenv
due toenv
being typed asany
- I had to specify
ServerlessEventObject
as the type parameter for an invocation ofconstructContext
- Added cookies attribute to
Contributing to Twilio
All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.
- [x] I acknowledge that all my contributions will be made under the project's license.
🦋 Changeset detected
Latest commit: ad52bb6469dbec6ab9639db2754bcb500acdbb54
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
Name | Type |
---|---|
twilio-run | Minor |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Hi @andrewbenington, thank you for submitting a PR to the serverless toolkit. At this time, it's unlikely we will be able to merge feature PRs for at least the near future. I'd like to keep this open since it's a good start at a needed improvement, but there are some things that would need to be addressed before merging this when the time comes.
Thanks again for taking the time to contribute a PR and apologies that we cannot move forward at present!