sample-appointment-reminders-node icon indicating copy to clipboard operation
sample-appointment-reminders-node copied to clipboard

Add "trigger notification" button to appointments

Open dkundel opened this issue 5 years ago • 3 comments

It would be great if you could send a notification manually by pressing a "trigger notification" button

dkundel avatar Dec 03 '19 21:12 dkundel

Question: would this work out the difference between now and the appointment time, and then queue immediately / soon?

I have a fix which should work for this which is to take the minutes between now and the time, and then store that instead of 5, 10, 15 etc.

  • It would stop it sending now and then again in {X} minutes / days etc
  • It would not be instant. I'd like to set it to the time the button is clicked + 1 minute, which I think is enough to be safe.
  • Because it mutates data, it means you could force a message to be sent twice without some form of UI or backend guard to ensure the notification has not already been sent.
  • Alternatives would be not modifying the data, but the schema to account for a log of when sent separate to scheduled to send.
    • At that point, how much of a sample is it, and how much of an application is it?
    • Like OpenVBX, would it rot? 😢

Lewiscowles1986 avatar Jan 16 '20 08:01 Lewiscowles1986

I'm open on the implementation. The problem with as largely that for people who want to quickly test the customer experience it was annoying to wait for a long time.

As for OpenVBX, we'll try to keep this and new sample apps as up-to-date as possible. These samples all aim at helping you to get started. But they will not be full fledged apps like OpenVBX or products like Flex. Instead we'll have a sample app per use case and host them on twilio.com/code-exchange.

That said we always love contributions :)

dkundel avatar Jan 17 '20 06:01 dkundel

I'm open on the implementation. The problem with as largely that for people who want to quickly test the customer experience it was annoying to wait for a long time.

In that case is it closable by the #34 because that allows 2 minute before time? No work is the best work

Ignore my salt RE: OpenVBX. It's still very cool and much thanks for Twilio's great devrel content and docs 🏆.

Lewiscowles1986 avatar Jan 20 '20 13:01 Lewiscowles1986