twilight icon indicating copy to clipboard operation
twilight copied to clipboard

Published 20 hours ago • verified publisher icon twilight-rs

refactor!: move `RequestReactionType` to model

Open vilgotf opened this issue 2 years ago • 3 comments

Whilst working on the HTTP ratelimiter, I discovered this specialized ReactionType model. Like other specialized models, they should go into twilight_model::http. Additionally, the custom emoji optional name field is removed as provides no utility.

I also temporarily depended on this change, but I've since refactored that code.

vilgotf avatar Feb 26 '23 08:02 vilgotf

Please resolve the merge conflicts and address zeylas review.

itohatweb avatar Apr 25 '23 17:04 itohatweb

This might not be necessary and either way it's on the backburner for now.

vilgotf avatar Jun 22 '23 13:06 vilgotf

This might not be necessary and either way it's on the backburner for now.

Why would this not be necessary? Seems like a reasonable change to me.

Gelbpunkt avatar Nov 24 '23 22:11 Gelbpunkt