twilight icon indicating copy to clipboard operation
twilight copied to clipboard

feat(http): impl `IntoFuture` for requests, deprecate `exec()`

Open vilgotf opened this issue 2 years ago • 2 comments

Depends upon #1897.

vilgotf avatar Sep 10 '22 20:09 vilgotf

Can the clippy lint be ignored? I think it's complaining about 0.14 not being defined (current Twilight version is 0.13). Should this PR bump all crates to 0.14?

vilgotf avatar Sep 22 '22 15:09 vilgotf

I think it wants you to say 0.14.0

7596ff avatar Sep 22 '22 19:09 7596ff

what do you think of putting this in response::future

pub(crate) type ResponseFutureOutput<T> = Result<Response<T>, Error>;

I'm generally not a big fan of types as they, without an IDE, can be irritating to resolve (especially private one's as rustdoc doesn't make them clickable).

vilgotf avatar Oct 03 '22 17:10 vilgotf