twilight
twilight copied to clipboard
refactor(model)!: clean up `AllowedMentions`
- flattens the
allowed_mentions
module intomessage
- removes
AllowedMentionsBuilder
(can be brought back into twilight-util if requested) - renames
ParseTypes
toMentionType
- rewrites the
AllowedMentions
documentation
Follow-up PR to discussion in #1792
Note that these types can be moved to the http
module, but I like their current placement.
Is there a reason of why the builder has been removed and has not been moved to util?
Is there a reason of why the builder has been removed and has not been moved to util?
I don't think there are any users of it that would not be happy with using ..Default::default()
. I'm happy to be proven wrong
Imho it's just a bit easier to use the builder, but ig using default works too.
I need to think more on what to do with the builder before I can approve this, but I've got my eye on it
@7596ff just a ping to see if we can get this moving