twilight icon indicating copy to clipboard operation
twilight copied to clipboard

refactor(model)!: clean up `AllowedMentions`

Open vilgotf opened this issue 2 years ago • 5 comments

  • flattens the allowed_mentions module into message
  • removes AllowedMentionsBuilder (can be brought back into twilight-util if requested)
  • renames ParseTypes to MentionType
  • rewrites the AllowedMentions documentation

Follow-up PR to discussion in #1792

vilgotf avatar Aug 14 '22 07:08 vilgotf

Note that these types can be moved to the http module, but I like their current placement.

vilgotf avatar Aug 14 '22 07:08 vilgotf

Is there a reason of why the builder has been removed and has not been moved to util?

itohatweb avatar Sep 01 '22 17:09 itohatweb

Is there a reason of why the builder has been removed and has not been moved to util?

I don't think there are any users of it that would not be happy with using ..Default::default(). I'm happy to be proven wrong

vilgotf avatar Sep 01 '22 17:09 vilgotf

Imho it's just a bit easier to use the builder, but ig using default works too.

itohatweb avatar Sep 01 '22 17:09 itohatweb

I need to think more on what to do with the builder before I can approve this, but I've got my eye on it

7596ff avatar Sep 01 '22 18:09 7596ff

@7596ff just a ping to see if we can get this moving

zeylahellyer avatar Jan 02 '23 17:01 zeylahellyer