twilight icon indicating copy to clipboard operation
twilight copied to clipboard

refactor(model)!: cleanup and document `voice`

Open vilgotf opened this issue 2 years ago • 1 comments

Documents all public items in the voice module. Removes CloseCodeConversionError and the undocumented VoiceState::token field.

vilgotf avatar Jul 06 '22 16:07 vilgotf

Should we apply the unknown variant changes to CloseCode? I think so, if a new one is added then users can use an unknown variant as a shim

I've tried my best to mirror gateway::CloseCode, and since that does not have it, I don't think this should either.

vilgotf avatar Jul 19 '22 05:07 vilgotf

Just the conflicts need to be resolved, then this PR is good to go.

itohatweb avatar Sep 16 '22 22:09 itohatweb