Issue #3828: Add sequence and mapping tests

[pdureau]

Add sequence and mapping tests from Jinja.

[pdureau]

Not 100% sure but I believe the fails reported by https://fabbot.io/report/twigphp/Twig/3859/508bc72c99bea1bfb69284610aaa154a3abeaf9a doesn't come from the code I have changed.

[smustgrave]

+1 for this feature. Working on a Drupal site and this causes issues for rendering lists.

[pdureau]

I have rebased my work with current 3.x branch, so my MR has changed.

[pdureau]

Hello all, my PR is ready for review.

[xabbuh]

fabbot suggests some changes that should be address: https://fabbot.io/report/twigphp/Twig/3859/5629adca007fc77574def9d5a309f713a95610ce

[pdureau]

Like last time, the 2 feedbacks from fabbot are not related to the code I have added or changed. Could a human do the review?

[xabbuh]

@fabpot Can you approve the workflow so that all jobs on GHA are triggered as well?

[pdureau]

thanks you @xabbuh I have added a new commit with:

• Missing blank lines before comments
• array_is_list() is not always part of the global namespace

[fabpot]

@fabpot Can you approve the workflow so that all jobs on GHA are triggered as well?

Done

[fabpot]

@pdureau We're almost there! Thank you for your patience and your hard work here. The last step before being able to merge (now that the names won't change anymore) is to add a note in CHANGELOG and documentation under doc/.

[pdureau]

@fabpot thanks for your message. I added a commit with a note in CHANGELOG and documentation under doc/. Very simple and straightforward, maybe too simple.

https://github.com/twigphp/Twig/pull/3859/commits/5c27e1a95d232014ceab651532df768ca38d77de

[fabpot]

Thank you @pdureau.