obsidian-execute-code icon indicating copy to clipboard operation
obsidian-execute-code copied to clipboard

Published 20 hours ago • verified publisher icon twibiral

[BUG] Killing a runtime leaves queued blocks unrunnable

Open milan338 opened this issue 2 years ago • 6 comments

When using an interactive runner like python, killing the runtime while blocks are queued will correctly kill the currently running block, however if there are other blocks queued (like waiting for time.sleep(100)), all the queued blocks will show the 'block running' indicator indefinitely, and the run code button will not show up.

milan338 avatar Oct 19 '22 04:10 milan338

This is odd, and almost certainly a regression, since this was one of the cases I specifically tested when developing the feature. I'll look into this later, but I have midterms at the moment so I'm a bit swamped; sorry!

chlohal avatar Oct 19 '22 11:10 chlohal

Did this happen since #138 or is it new?

chlohal avatar Oct 19 '22 12:10 chlohal

It happens on the current main branch.

milan338 avatar Oct 19 '22 13:10 milan338

Gotcha, thanks. I think I found the issue & I just made a PR-- does #139 fix the problem on your machine?

chlohal avatar Oct 19 '22 13:10 chlohal

Can this be closed? (sorry)

chlohal avatar Oct 19 '22 23:10 chlohal

Thanks for the fix, works on my end. I think this can be closed.

milan338 avatar Oct 20 '22 01:10 milan338