Thomas Werkmeister

Results 38 comments of Thomas Werkmeister

Ok seems it's mostly some type annotations in the code quality that block the checks from passing. Looking through the change logs for 1.20 and 1.21 I didn't find anything...

Well actually it's 70 mypy errors... definitely not something to do in an afternoon

@melindaloubser1 thanks for going ahead and merging, I was a bit behind on this! 🙌🌟

Hi @yuxuan2015, this is most likely due to the different yaml parser being used by rasa, which does a lot of extra checks to keep ordering and comments in files....

Closing this as it does not look like this line of work yielded improvements.

Hey @francopierre thank you for your PR. To review and assess it though, we definitely need some high level description of what it tries to achieve

The way I understand this, this is a tf 2.7 testing branch. We had already switched to tf 2.7 a while ago. Closing for now

This is definitely a bug and should be fixed 👍

Actually, I was wrong. I did some more investigation and found: * It's been like this since Rasa 1.6 (the oldest branch I could find) * It's done like this...