twenty icon indicating copy to clipboard operation
twenty copied to clipboard

Clicking a phone number should copy its value

Open Bonapara opened this issue 1 year ago • 9 comments

Current behavior

Clicking on a phone number navigates to the phone app

https://github.com/user-attachments/assets/2684c5d9-1595-4277-afe9-3957c4b8d27c

Desired Behavior

The default behavior should be to copy the phone number to the clipboard and display a notification

Image

Bonapara avatar Dec 05 '24 15:12 Bonapara

i want to work on this issue

shivankurchavan avatar Dec 05 '24 19:12 shivankurchavan

@Bonapara can I work on this issue?

Lucifer4255 avatar Dec 05 '24 19:12 Lucifer4255

Maybe you can do some peer coding @shivankurchavan and @Lucifer4255?

Bonapara avatar Dec 06 '24 08:12 Bonapara

@shivankurchavan up for peer coding?

Lucifer4255 avatar Dec 06 '24 15:12 Lucifer4255

@Bonapara I looked into the codebase but I couldn't find any component to show the notification should I create it on my own?

Lucifer4255 avatar Dec 10 '24 15:12 Lucifer4255

@Lucifer4255 I guess there is already a component called snackbar.

harshrajeevsingh avatar Dec 10 '24 16:12 harshrajeevsingh

Right! https://storybook.twenty.com/?path=/story/ui-feedback-snackbarmanager-snackbar--default

Bonapara avatar Dec 12 '24 10:12 Bonapara

@Bonapara Since no one is working on this issue i guess can you assign it to me im merging a PR for closing this issue you can check there

Lucifer4255 avatar Dec 13 '24 18:12 Lucifer4255

@shivankurchavan up for peer coding?

Good job fixing this issue, kudos. Can you help me in setting up the project ? Im facing some issues

shivankurchavan avatar Dec 13 '24 19:12 shivankurchavan