twenty icon indicating copy to clipboard operation
twenty copied to clipboard

Added "Select an option" as default none selector on Workflow Visualizer

Open AndrewHamal opened this issue 1 year ago • 4 comments

What does this PR do?

Shows "Select an option" as a default selector on the select component for the trigger step in the workflow visualizer

Fixes #7432

Screenshot 2024-10-20 at 12 48 39 AM Screenshot 2024-10-20 at 12 48 50 AM

AndrewHamal avatar Oct 19 '24 19:10 AndrewHamal

@Bonapara I think we want something like No value in our select field type ?

lucasbordeau avatar Oct 21 '24 10:10 lucasbordeau

It doesn't really make sense to have a trigger without an object, but we can use No value indeed.

Bonapara avatar Oct 21 '24 12:10 Bonapara

@Bonapara you mean with out anything remove "Select an option" and have empty nothing selected at first?

AndrewHamal avatar Oct 21 '24 18:10 AndrewHamal

After further thought, I think it's okay to have the empty state only when no object has been selected "Select an Option", and to only have the ability to switch between objects without the option to reset to null/select an Option when one gets selected.

Bonapara avatar Oct 22 '24 08:10 Bonapara

Hello @AndrewHamal, I pushed an update to your code to use pre-existing solutions I didn't know about when I created the issue. You will get the OSS points. Thanks for your contribution.

Devessier avatar Oct 23 '24 13:10 Devessier

Awarding AndrewHamal: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/AndrewHamal

oss-gg[bot] avatar Oct 24 '24 08:10 oss-gg[bot]