Field on label should change singular to plural based on relation type

[ehconitin]

Current behavior

1. The field on label is populated with active object, and it doesn't change singular to plural or vice versa based on relation type.

Expected behavior

1. The label field on should automatically change from singular to plural (or vice versa) based on the relation type, unless the user manually edits or changes the field.

[oss-gg[bot]]

This issue is not part of oss.gg hackathon. Please pick a different one or start with a side quest

[ehconitin]

/oss.gg 200

[oss-gg[bot]]

Thanks for opening an issue! It's live on oss.gg!

[bunmi-oye]

/assign

[oss-gg[bot]]

Assigned to @Cyanhead! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

[malavshah9]

/assign

[oss-gg[bot]]

This issue is already assigned to another person. Please find more issues here.

[bibektamang7]

/assign

[oss-gg[bot]]

This issue is already assigned to another person. Please find more issues here.

[oss-gg[bot]]

@Cyanhead, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

[Vardhaman619]

/assign

[oss-gg[bot]]

This issue is already assigned to another person. Please find more issues here.

[bunmi-oye]

Hi @ehconitin, I'm having some difficulty with where exactly to implement the fix for this issue. I have an idea of the cause, but i'm not sure where/how to pass the data.

PHOTO A: It looks like the reason the plural is not being applied is because the initialRelationFieldMetadataItem.label gotten from the useRelationSettingsFormInitialValues hook doesn't get assigned the correct value.

PHOTO B: initialRelationType receives relationTypeFromFieldMetadata as undefined and defaults to RelationDefinitionType.OneToMany.

PHOTO C: The SettingsDataModelFieldSettingsFormCard component passes three properties, of which relationDefinition needed by the useRelationSettingsFormInitialValues isn't included.

[P4rthPat3l]

/assign

[oss-gg[bot]]

This issue is already assigned to another person. Please find more issues here.

[vamus092]

/assign

[oss-gg[bot]]

This issue is already assigned to another person. Please find more issues here.

[omarNaifer12]

@ehconitin Hello, is this issue still available? Can I work on it?

[omarNaifer12]

/assign

[oss-gg[bot]]

This issue is not part of oss.gg hackathon. Please pick a different one or start with a side quest

[omarNaifer12]

@FelixMalfait @ehconitin Hello, Sorry for working on this before being assigned. I've completed the task and made a pull request. Please review and let me know if any changes are needed.

Thank you!

[ehconitin]

@omarNaifer12 no problem! Thanks 😊