twenty icon indicating copy to clipboard operation
twenty copied to clipboard

Center Functions Empty state

Open Bonapara opened this issue 1 year ago • 12 comments

Current Behavior

CleanShot 2024-09-12 at 16 03 05

The empty state is not aligned on the page center

Desired Behavior

image

Center the empty state

Bonapara avatar Sep 12 '24 14:09 Bonapara

hey i would like to work on this.

chistym17 avatar Sep 12 '24 14:09 chistym17

Sure @chistym17, thanks for contributing!

Bonapara avatar Sep 12 '24 16:09 Bonapara

Hi @Bonapara , I looked into the issue, the issue persists because OBJECT_SETTINGS_WIDTH is hardcoded to 512 px, that is the reason why <SettingsServerlessFunctionsTableEmpty/> is centred to its parents 512 px width, not where it supposed to. I can't think of a solution, also someone else has marked it to solve..

kant-github avatar Sep 13 '24 09:09 kant-github

@kant-github hey if you find the solution feel free to solve it. i am having some problems with the frontend localhost..

chistym17 avatar Sep 13 '24 10:09 chistym17

Hi @Bonapara , I looked into the issue, the issue persists because OBJECT_SETTINGS_WIDTH is hardcoded to 512 px, that is the reason why is centred to its parents 512 px width, not where it supposed to. I can't think of a solution, also someone else has marked it to solve..

The 512px width is expected, we should just make an exception for Settings empty states. Thanks!

Bonapara avatar Sep 13 '24 13:09 Bonapara

Is this issue resolved, it is center aligned for me in the empty state.

rajeshkrishnait avatar Sep 14 '24 13:09 rajeshkrishnait

CleanShot 2024-09-18 at 09 58 16

Not fixed!

Bonapara avatar Sep 18 '24 07:09 Bonapara

I will take a look to see if I can fix this...

admodev avatar Sep 20 '24 19:09 admodev

/oss.gg 150

Bonapara avatar Oct 01 '24 19:10 Bonapara

Thanks for opening an issue! It's live on oss.gg!

oss-gg[bot] avatar Oct 01 '24 19:10 oss-gg[bot]

Hey @Bonapara I've submitted a PR that fixes the issue. Please review it when you have a chance. Thank you!

Utzig26 avatar Oct 02 '24 04:10 Utzig26

Thanks @Utzig26, the team will review it shortly!

Bonapara avatar Oct 02 '24 07:10 Bonapara