twenty icon indicating copy to clipboard operation
twenty copied to clipboard

CurrencyField Isn't Showing 0 on cell and record page and by default doesn't differentiate between empty and zero when changing to empty

Open Nabhag8848 opened this issue 1 year ago • 8 comments

Bug Description

  • [ ] Doesn't diffrentiate between Zero as currency value and Empty.
  • [ ] Doesn't show Zero as Currency Value on Record Cell and Record Page.

https://github.com/user-attachments/assets/15e5bd66-7f8f-406c-bc84-91d46d4ae380

Nabhag8848 avatar Aug 30 '24 08:08 Nabhag8848

Hey @Nabhag8848

I would like to work on this issue. Can you please assign this issue to me.

Thanks

nicck1 avatar Aug 31 '24 05:08 nicck1

Thanks for reporting!

What we want:

  • in database, the empty value should be a NULL value ; a 0 should be 0
  • in FE, if empty is should be fully blank in RecordTableCell and (Empty) in RecordInlineCell on showPage and board cards

charlesBochet avatar Sep 01 '24 11:09 charlesBochet

@shagunsharma6677 Assigning you, thank you!

charlesBochet avatar Sep 01 '24 11:09 charlesBochet

/oss.gg 150

Bonapara avatar Oct 01 '24 19:10 Bonapara

Thanks for opening an issue! It's live on oss.gg!

oss-gg[bot] avatar Oct 01 '24 19:10 oss-gg[bot]

Hi @charlesBochet , I'd love to work on this and will create a PR soon.

nganphan123 avatar Oct 02 '24 08:10 nganphan123

/assign

nganphan123 avatar Oct 03 '24 04:10 nganphan123

Assigned to @nganphan123! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

oss-gg[bot] avatar Oct 03 '24 04:10 oss-gg[bot]

You already have an open issue assigned to you here. Once that's closed or unassigned, only then we recommend you to take up more.

oss-gg[bot] avatar Oct 08 '24 04:10 oss-gg[bot]