twenty icon indicating copy to clipboard operation
twenty copied to clipboard

When scrolling inside the table with scrollbar, cursor also selects rows

Open BOHEUS opened this issue 1 year ago â€ĸ 36 comments

Scenario:

  1. Log in
  2. Go to object page (e.g. Companies)
  3. Create at least 100 records so table won't be able to load them all thanks to pagination and scroll will appear
  4. Scroll a bit for the scrollbar to appear and try to use scrollbar to move up/down the table

Actual: When moving scrollbar, cursor also is able to select multiple rows Screencast from 2024-08-28 18-35-28.webm

Expected: When moving scrollbar, cursor is only moving scrollbar

BOHEUS avatar Aug 28 '24 16:08 BOHEUS

@BOHEUS I would like to work here.

Faisal-imtiyaz123 avatar Aug 29 '24 07:08 Faisal-imtiyaz123

Sure @Faisal-imtiyaz123, thanks for contributing!

Bonapara avatar Aug 29 '24 09:08 Bonapara

I would like to work on this @Bonapara

janvi01 avatar Aug 31 '24 17:08 janvi01

I can reproduce should be easy to fix, we should de-activate the drag start on the scrollbar. We already have this kind of mechanism to not start the drag on column header click

charlesBochet avatar Sep 01 '24 12:09 charlesBochet

@Faisal-imtiyaz123 are you still on it? Otherwise will assign you @janvi01. Thank you both for contributing!

Bonapara avatar Sep 02 '24 08:09 Bonapara

@Bonapara I am on it.

Faisal-imtiyaz123 avatar Sep 02 '24 09:09 Faisal-imtiyaz123

@BOHEUS I made 120 objects . Couldn't reproduce it. Are you sure it wasn't an accidental selection which caused rows to be selected.

Faisal-imtiyaz123 avatar Sep 04 '24 12:09 Faisal-imtiyaz123

@Faisal-imtiyaz123 I'm still reproducing it, both locally on newest changes and on demo, I'm sure it wasn't an accidental selection as I clicked on scroll (sadly, it's not visible on video as software didn't capture a cursor for some weird reason) and @charlesBochet confirmed it can be reproduced, I also checked and it's not limited to specific browser like it's in some cases

BOHEUS avatar Sep 04 '24 16:09 BOHEUS

@BOHEUS Oh! I think it is reproducible when number of objects is large. Let me create a large number of objects and then see.

Faisal-imtiyaz123 avatar Sep 04 '24 17:09 Faisal-imtiyaz123

/oss.gg 150

Bonapara avatar Oct 01 '24 20:10 Bonapara

Thanks for opening an issue! It's live on oss.gg!

oss-gg[bot] avatar Oct 01 '24 20:10 oss-gg[bot]

/assign

Prathamm-sahu avatar Oct 08 '24 09:10 Prathamm-sahu

Assigned to @Prathamm-sahu! Please open a draft PR linking this issue within 48h âš ī¸ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically đŸ•šī¸ Excited to have you ship this 🚀

oss-gg[bot] avatar Oct 08 '24 09:10 oss-gg[bot]

@Prathamm-sahu, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

oss-gg[bot] avatar Oct 09 '24 21:10 oss-gg[bot]

/assign

HarshBytesCode avatar Oct 11 '24 05:10 HarshBytesCode

This issue is already assigned to another person. Please find more issues here.

oss-gg[bot] avatar Oct 11 '24 05:10 oss-gg[bot]

/assign

Anky9972 avatar Oct 11 '24 13:10 Anky9972

This issue is already assigned to another person. Please find more issues here.

oss-gg[bot] avatar Oct 11 '24 13:10 oss-gg[bot]

/assign

xRiddin avatar Oct 11 '24 16:10 xRiddin

This issue is already assigned to another person. Please find more issues here.

oss-gg[bot] avatar Oct 11 '24 16:10 oss-gg[bot]

@Prathamm-sahu, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

oss-gg[bot] avatar Oct 11 '24 21:10 oss-gg[bot]

/assign

hr188 avatar Oct 12 '24 02:10 hr188

This issue is already assigned to another person. Please find more issues here.

oss-gg[bot] avatar Oct 12 '24 02:10 oss-gg[bot]

/assign

TechWithAkash avatar Oct 12 '24 07:10 TechWithAkash

This issue is already assigned to another person. Please find more issues here.

oss-gg[bot] avatar Oct 12 '24 07:10 oss-gg[bot]

/unassign

charlesBochet avatar Oct 13 '24 09:10 charlesBochet

Issue unassigned.

oss-gg[bot] avatar Oct 13 '24 09:10 oss-gg[bot]

/assign

TriDev5 avatar Oct 13 '24 09:10 TriDev5

Assigned to @TriDev5! Please open a draft PR linking this issue within 48h âš ī¸ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically đŸ•šī¸ Excited to have you ship this 🚀

oss-gg[bot] avatar Oct 13 '24 09:10 oss-gg[bot]

/assign

Sukhpreet7137 avatar Oct 13 '24 14:10 Sukhpreet7137