Create congratulations bot

[ady-beraud]

• Created congratulations bot :

• Modified OG image

• Added png extension to OG image route

To be noted: The bot will not work until the new API route is not deployed. Please check OG image with Cloudflare cache.

[github-actions[bot]]

	Fails
:no_entry_sign:	node failed.

Log

[31mError: [39m RequestError [HttpError]: Not Found
    at /home/runner/work/twenty/twenty/node_modules/[4m@octokit[24m/request/dist-node/index.js:86:21
[90m    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)[39m {
  status: [33m404[39m,
  response: {
    url: [32m'https://api.github.com/orgs/twentyhq/teams/core-team/members'[39m,
    status: [33m404[39m,
    headers: {
      [32m'access-control-allow-origin'[39m: [32m'*'[39m,
      [32m'access-control-expose-headers'[39m: [32m'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset'[39m,
      connection: [32m'close'[39m,
      [32m'content-encoding'[39m: [32m'gzip'[39m,
      [32m'content-security-policy'[39m: [32m"default-src 'none'"[39m,
      [32m'content-type'[39m: [32m'application/json; charset=utf-8'[39m,
      date: [32m'Tue, 21 May 2024 20:57:19 GMT'[39m,
      [32m'referrer-policy'[39m: [32m'origin-when-cross-origin, strict-origin-when-cross-origin'[39m,
      server: [32m'GitHub.com'[39m,
      [32m'strict-transport-security'[39m: [32m'max-age=31536000; includeSubdomains; preload'[39m,
      [32m'transfer-encoding'[39m: [32m'chunked'[39m,
      vary: [32m'Accept-Encoding, Accept, X-Requested-With'[39m,
      [32m'x-accepted-github-permissions'[39m: [32m'members=read'[39m,
      [32m'x-content-type-options'[39m: [32m'nosniff'[39m,
      [32m'x-frame-options'[39m: [32m'deny'[39m,
      [32m'x-github-api-version-selected'[39m: [32m'2022-11-28'[39m,
      [32m'x-github-media-type'[39m: [32m'github.v3; format=json'[39m,
      [32m'x-github-request-id'[39m: [32m'5417:2F9E28:5C35F18:AA47598:664D0AAF'[39m,
      [32m'x-ratelimit-limit'[39m: [32m'15000'[39m,
      [32m'x-ratelimit-remaining'[39m: [32m'14990'[39m,
      [32m'x-ratelimit-reset'[39m: [32m'1716328604'[39m,
      [32m'x-ratelimit-resource'[39m: [32m'core'[39m,
      [32m'x-ratelimit-used'[39m: [32m'10'[39m,
      [32m'x-xss-protection'[39m: [32m'0'[39m
    },
    data: {
      message: [32m'Not Found'[39m,
      documentation_url: [32m'https://docs.github.com/rest/teams/members#list-team-members'[39m
    }
  },
  request: {
    method: [32m'GET'[39m,
    url: [32m'https://api.github.com/orgs/twentyhq/teams/core-team/members'[39m,
    headers: {
      accept: [32m'application/vnd.github.v3+json'[39m,
      [32m'user-agent'[39m: [32m'octokit-rest.js/18.12.0 octokit-core.js/3.6.0 Node.js/18.20.2 (linux; x64)'[39m,
      authorization: [32m'token [REDACTED]'[39m
    },
    request: { hook: [36m[Function: bound bound register][39m }
  }
}
danger-results://tmp/danger-results-b024dd37.json

Generated by :no_entry_sign: dangerJS against 375518bdb8756349694c7906371eb2b1b05b66d7

[FelixMalfait]

I think this is very cool! The only downside is that this really emphasizes quantity and not quality.

@brendanlaschke what do you think? do you find this spammy? any idea on how to value quality more than # of PRs?

[brendanlaschke]

I think this is very cool! The only downside is that this really emphasizes quantity and not quality.

@brendanlaschke what do you think? do you find this spammy? any idea on how to value quality more than # of PRs?

I love the idea! I think its fine if you get a notification per pr - For me they are grouped and easy deleted but I think not everyone shares this opinion :)

I don't really know what metric is as easy and fair as pr count. Already lines of code have other problems like package installation and other generated files.

Interesting would be maybe a tagging of contribution / contributor by package (front, server, chrome-extension, docker, docs, website, ...). But how or if this is possible with the data we can get from GitHub im not sure ...

[FelixMalfait]

Thanks! I guess we can better leverage labels later for quality/analysis. We already sync those labels from Github to twenty-website's database so it's available

[ady-beraud]

• Added a partial sync
• Removed bot for first PR
• Removed bot for team members
• Added job to CI -> one workflow