twenty icon indicating copy to clipboard operation
twenty copied to clipboard

WIP Add Object Alternative view

Open brendanlaschke opened this issue 9 months ago • 4 comments

Current state:

Bildschirmfoto 2024-05-11 um 17 57 33

I have some things im not really happy with right now:

  • If I have different connections it would be weird to display a one_one or many_one connection differently
  • The edges overlay always at one hand at the source/target (also being a problem with the 3 dots vs 1 dot)
  • I would have to do 4 versions of the 3 dot marker variant as an svg with exactly the same width as the edges wich is not as easy as it seems :)
  • The initial layout is not really great - I know dagre or elkjs could solve this but maybe there is a better solution ...

If someone has a good idea for one or more of the problems im happy to integrate them ;)

brendanlaschke avatar May 11 '24 16:05 brendanlaschke

I'm a big fan of this PR! I'm taking a look this afternoon

charlesBochet avatar May 22 '24 09:05 charlesBochet

I'm a big fan of this PR! I'm taking a look this afternoon

Just pushed some changes its now somewhere between doing connections on all fields (which im a fan of but not had the time to reimplement on the new design) and the version showing only one connection per object.

Bildschirmfoto 2024-05-22 um 13 15 36

brendanlaschke avatar May 22 '24 11:05 brendanlaschke

Really great work!!! I agree having the connections at the field level would make this more useful. I pushed a basic implem of dagre. I'm not sure if it's much better, the positioning is nicer. But it seems it broke fitview somehow? Or is it only for me?

FelixMalfait avatar May 22 '24 16:05 FelixMalfait

Really great work!!! I agree having the connections at the field level would make this more useful. I pushed a basic implem of dagre. I'm not sure if it's much better, the positioning is nicer. But it seems it broke fitview somehow? Or is it only for me?

I just have done the work on the field based edges:

Bildschirmfoto 2024-05-22 um 20 07 29

Initally it now looks like this:

Bildschirmfoto 2024-05-22 um 20 14 48

Do you mean this with not fitted?

brendanlaschke avatar May 22 '24 18:05 brendanlaschke

Thanks @brendanlaschke for your contribution! This marks your 93rd PR on the repo. You're top 1% of all our contributors 🎉 See contributor page - Share on LinkedIn - Share on Twitter

Contributions

github-actions[bot] avatar May 25 '24 08:05 github-actions[bot]

just FYI @Bonapara this was merged over the week-end so should be part of Monday's release

FelixMalfait avatar May 26 '24 16:05 FelixMalfait