twenty icon indicating copy to clipboard operation
twenty copied to clipboard

Merge env-config.js into index.html

Open FelixMalfait opened this issue 9 months ago • 14 comments

Env-config.js is render-blocking and takes 250ms to load on average! By simply moving it within index.html we could probably save 250ms of every initial page/new tab load!

Screenshot 2024-05-08 at 17 42 48

We should replace <script src="/env-config.js"></script> and directly overwrite the index.html file

FelixMalfait avatar May 08 '24 15:05 FelixMalfait

/assign

vamus092 avatar Oct 27 '24 05:10 vamus092

This issue is not part of oss.gg hackathon. Please pick a different one or start with a side quest

oss-gg[bot] avatar Oct 27 '24 05:10 oss-gg[bot]

/oss.gg 500

FelixMalfait avatar Oct 27 '24 05:10 FelixMalfait

Thanks for opening an issue! It's live on oss.gg!

oss-gg[bot] avatar Oct 27 '24 05:10 oss-gg[bot]

Make sure to edit all file/build processes that reference env-config

FelixMalfait avatar Oct 27 '24 05:10 FelixMalfait

surw @FelixMalfait

vamus092 avatar Oct 27 '24 05:10 vamus092

hey @FelixMalfait i have created the PR, check for the performance...🫱🏼‍🫲🏼

vamus092 avatar Oct 27 '24 16:10 vamus092

/assign

AkashJana18 avatar Oct 28 '24 07:10 AkashJana18

Assigned to @AkashJana18! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

oss-gg[bot] avatar Oct 28 '24 07:10 oss-gg[bot]

Hey @vamus092 @FelixMalfait is this issue resolved? I would like to know how much you worked on it or so @vamus092

AkashJana18 avatar Oct 28 '24 07:10 AkashJana18

Hey @AkashJana18 - see @vamus092's PR: https://github.com/twentyhq/twenty/pull/8127

FelixMalfait avatar Oct 28 '24 07:10 FelixMalfait

@AkashJana18, please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12 hours, you will be unassigned automatically.

oss-gg[bot] avatar Oct 31 '24 07:10 oss-gg[bot]