twenty icon indicating copy to clipboard operation
twenty copied to clipboard

Feat/migrate password reset token to app token table

Open pacyL2K19 opened this issue 1 year ago • 1 comments

This PR

  • Fix #5021
  • Migrates passwordResetToken and passwordResetTokenExpiresAt fields from core.users to core.appToken
  • Marks those fields as deprecated so we can remove them later if we are happy with the transition -- I took this decision on my own, @FellipeMTX let me know what you think about it, we can also remove them straight away if you think it's better
  • Fixed the database:migration script from the twenty-server to:
    "database:migrate": {
      "executor": "nx:run-commands",
      "dependsOn": ["build"], // added this line
      "options": {
        "cwd": "packages/twenty-server",
        "commands": [
          "nx typeorm -- migration:run -d src/database/typeorm/metadata/metadata.datasource",
          "nx typeorm -- migration:run -d src/database/typeorm/core/core.datasource"
        ],
        "parallel": false
      }
    },

The migration script wasn't running because the builds were not executed

  • [x] Added unit tests for the token.service file's changes

Looking forward to hearing feedback from you

cc: @charlesBochet

pacyL2K19 avatar Apr 19 '24 12:04 pacyL2K19

sorry for the slow reviews!

FelixMalfait avatar May 03 '24 13:05 FelixMalfait

LGTM thank you @pacyL2K19! I've added invalidation logic to your PR

Thank you @Weiko Looking forward to grab more issues, if you have any to suggest, please do

pacyL2K19 avatar May 06 '24 15:05 pacyL2K19