twenty icon indicating copy to clipboard operation
twenty copied to clipboard

Fix dark mode in multi-select picker

Open FelixMalfait opened this issue 10 months ago • 13 comments

Dark mode looks awful when you try to see the full list of selected items (type on "+15" if you have 17 items)

Screenshot 2024-04-15 at 18 27 02

FelixMalfait avatar Apr 15 '24 16:04 FelixMalfait

The background should be Transparent Secondary with the blurred backdrop-filter

Bonapara avatar Apr 15 '24 19:04 Bonapara

Hi @FelixMalfait, @Bonapara can I work on this issue?

sakshi4321 avatar Apr 17 '24 01:04 sakshi4321

hey @FelixMalfait i would very much like to contribute to this issue if no one is working on it Thank You....!!

Albert-2 avatar Apr 18 '24 19:04 Albert-2

@Albert-2 great feel free to raise a PR! Thanks

FelixMalfait avatar Apr 19 '24 14:04 FelixMalfait

@FelixMalfait you mean create new issue.....??

Albert-2 avatar Apr 19 '24 15:04 Albert-2

@Albert-2 a pull request

FelixMalfait avatar Apr 19 '24 15:04 FelixMalfait

ok @FelixMalfait I will but can you please assign me the issue as well

Albert-2 avatar Apr 19 '24 15:04 Albert-2

Sure, should be a one-line change so not too long that's why I assumed it was as fast to just raise a PR 😁 (and that @sakshi4321 I considered you probably moved away from the task)

Thanks!

FelixMalfait avatar Apr 19 '24 15:04 FelixMalfait

hey @FelixMalfait Sorry brother, i seriously tried my best but the project is quite complex for me hope you will consider Thank You

Albert-2 avatar Apr 20 '24 12:04 Albert-2

Hi! I'll create a PR to fix this issue. @FelixMalfait can you assign me to it?

orinamio avatar Apr 20 '24 14:04 orinamio

Has this issue been resolved? Unable to reproduce the bug. Otherwise, @FelixMalfait can you provide clearer instructions on how reproduce it?

Here's a video of my test:

https://github.com/twentyhq/twenty/assets/16918891/19ff5b0f-bf32-4a22-90a7-79d1622698d6

orinamio avatar Apr 20 '24 15:04 orinamio

Hi @orinamio, to me, this issue concerns the expanded cell that appears when clicking the +X tag, which is displayed when there are more tags than the available width can accommodate.

Try to add more context to see the +X appear!

Bonapara avatar Apr 22 '24 08:04 Bonapara

Found it and creating a PR to fix it. Thanks for the insight.

orinamio avatar Apr 22 '24 19:04 orinamio