twenty icon indicating copy to clipboard operation
twenty copied to clipboard

Add Buttons Shortcuts Helpers to the Design System

Open Bonapara opened this issue 10 months ago ā€¢ 41 comments

Desired Behavior

We're planning to introduce an optional shortcut helper on buttons, with color variations (for text and vertical separator) based on different variants.

The separator and shortcut helper colors are different.

CleanShot 2024-04-08 at 10 38 26

Figma

https://www.figma.com/file/xt8O9mFeLl46C5InWwoMrN/Twenty?type=design&node-id=27442-83448&mode=design&t=rBbwIqCdtFV9i9Jg-11

Bonapara avatar Apr 08 '24 08:04 Bonapara

@DevStackArchitect You can ask for help in Discord :)

Bonapara avatar Apr 10 '24 17:04 Bonapara

Hey @Bonapara!

Mind if I work on this?

jss475 avatar May 08 '24 21:05 jss475

Sure @jss475, Thanks!

Bonapara avatar May 09 '24 10:05 Bonapara

Hi @jss475, I'm unassigning you. Ping me if you still want it!

Bonapara avatar Jul 01 '24 17:07 Bonapara

@Bonapara Couldnt find these in figma. Could you please reshare the figma designs.

ehconitin avatar Aug 12 '24 10:08 ehconitin

@Mihan786Chistie You can work on this issue

lucasbordeau avatar Aug 20 '24 14:08 lucasbordeau

Thanks @lucasbordeau, looking into it

Mihan786Chistie avatar Aug 20 '24 15:08 Mihan786Chistie

@Bonapara can you give more details for the issue. I am still very confused about it. Also the Figma designs doesn't seem to be updated as the one provided for the issue

Mihan786Chistie avatar Sep 03 '24 04:09 Mihan786Chistie

The shortcuts helper are there but hidden otherwise they would appear everywhere in the Figma šŸ˜„

Duplicated the file and displayed them here: https://www.figma.com/design/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=38933-151210&node-type=FRAME&t=1bOEBMGNbJiNYwdc-11

Thanks @Mihan786Chistie!

Bonapara avatar Sep 03 '24 07:09 Bonapara

Thanks for the clarification! I checked out the Figma file, but Iā€™m still a bit confused about how to implement the color variations for the shortcut helper and separator. Could you guide me on how these color changes should be applied?@Bonapara

Mihan786Chistie avatar Sep 03 '24 07:09 Mihan786Chistie

/oss.gg 150

Bonapara avatar Oct 02 '24 07:10 Bonapara

Thanks for opening an issue! It's live on oss.gg!

oss-gg[bot] avatar Oct 02 '24 07:10 oss-gg[bot]

@Bonapara Is the goal to enhance the existing button component (Button.tsx) with a keyboard shortcut action based on the provided Figma design, or should a new button component be composed for this?

unrenamed avatar Oct 08 '24 11:10 unrenamed

Let's just start with the UI for now! Thanks @unrenamed

Bonapara avatar Oct 08 '24 15:10 Bonapara

/assign

unrenamed avatar Oct 08 '24 16:10 unrenamed

Assigned to @unrenamed! Please open a draft PR linking this issue within 48h āš ļø If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically šŸ•¹ļø Excited to have you ship this šŸš€

oss-gg[bot] avatar Oct 08 '24 16:10 oss-gg[bot]

@unrenamed, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

oss-gg[bot] avatar Oct 10 '24 04:10 oss-gg[bot]

/assign

PremPrakashCodes avatar Oct 10 '24 13:10 PremPrakashCodes

This issue is already assigned to another person. Please find more issues here.

oss-gg[bot] avatar Oct 10 '24 13:10 oss-gg[bot]

This issue is already assigned to another person. Please find more issues here.

oss-gg[bot] avatar Oct 10 '24 16:10 oss-gg[bot]

/assign

AdityaJadhav9423 avatar Oct 10 '24 16:10 AdityaJadhav9423

Assigned to @AdityaJadhav9423! Please open a draft PR linking this issue within 48h āš ļø If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically šŸ•¹ļø Excited to have you ship this šŸš€

oss-gg[bot] avatar Oct 10 '24 16:10 oss-gg[bot]

/assign

SaurabhRadke avatar Oct 11 '24 08:10 SaurabhRadke

This issue is already assigned to another person. Please find more issues here.

oss-gg[bot] avatar Oct 11 '24 08:10 oss-gg[bot]

@unrenamed, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

oss-gg[bot] avatar Oct 12 '24 04:10 oss-gg[bot]

@AdityaJadhav9423, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

oss-gg[bot] avatar Oct 12 '24 04:10 oss-gg[bot]

This issue is already assigned to another person. Please find more issues here.

oss-gg[bot] avatar Oct 12 '24 16:10 oss-gg[bot]

@unrenamed, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

oss-gg[bot] avatar Oct 14 '24 04:10 oss-gg[bot]

@AdityaJadhav9423, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

oss-gg[bot] avatar Oct 14 '24 04:10 oss-gg[bot]

@AdityaJadhav9423, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

oss-gg[bot] avatar Oct 16 '24 04:10 oss-gg[bot]