twenty icon indicating copy to clipboard operation
twenty copied to clipboard

New "inverted" Background Colors

Open Bonapara opened this issue 1 year ago • 2 comments

Desired Behavior

We want to introduce 2 new Inverted background colors in the theme:

Inverted - Secondary Inverted - Primary

Inverted - Secondary will be used as the gray Neutral banner background.

Properties

CleanShot 2024-04-01 at 11 38 47@2x

Bonapara avatar Apr 01 '24 09:04 Bonapara

@Bonapara can you assign me this issue?

shree-1788 avatar Apr 01 '24 14:04 shree-1788

Sure, thanks @shree-1788!

Bonapara avatar Apr 01 '24 15:04 Bonapara

@Bonapara Would love to take a look into this.. can you please provide a bit more info?

DecodersLord avatar Jul 19 '24 15:07 DecodersLord

The goal is to introduce these 2 new colors in the design system :)

Bonapara avatar Jul 19 '24 15:07 Bonapara

@Bonapara I guess I have made the correct changes by editing BackgroundLight and BackgroundDarak files as below

image

However, when trying to build twenty-ui using npx I run into below error on my WSL 2 Ubuntu machine. Is it just my machine or I am missing any pre-requisites? (All the build requirements before this works and I can even hit the server at http://localhost:3000/graphql.)

image

The test twenty-ui passes but I guess that doesn't necessarily test the changes image

DecodersLord avatar Jul 19 '24 19:07 DecodersLord

I see #6329 reporting the same but with no resolution.

DecodersLord avatar Jul 20 '24 04:07 DecodersLord

@lucasbordeau any input?

Bonapara avatar Jul 22 '24 08:07 Bonapara

Fixed with #6354

ijreilly avatar Jul 22 '24 10:07 ijreilly