twenty icon indicating copy to clipboard operation
twenty copied to clipboard

In the opportunities kanban, put the new button at the top of the page, not the bottom

Open pombredanne opened this issue 11 months ago • 4 comments

In the opportunities kanban, put the new button at the top of the page, not the bottom. Otherwise, it forces to scroll all the way down as soon as you have more than a few oppties

pombredanne avatar Mar 23 '24 12:03 pombredanne

Mmh great point we used to have a button on top right and it's just disappeared during the refactoring last week. We need to add it back (but it's a special type of button so it's not that easy, might take a bit of time)

FelixMalfait avatar Mar 24 '24 21:03 FelixMalfait

This is a bit of a PITA when there are many opportunities FWIW. Each page seems to have the "new" button positioned at different places... consistency would help a lot.

As reported elsewhere, not being able to create new records from the list or details of other records is also a minor PITA

Here are the current positions:

  • opportunities kanban: bottom left corner
  • opportunities list: upper right corner
  • people list: upper right corner and also in the name in the first/title row of the list
  • companies list: upper right corner and also in the name in the first/title row of the list

pombredanne avatar Apr 26 '24 13:04 pombredanne

I agree! We'll improve this

@Bonapara fyi if you didn't see this already

FelixMalfait avatar Apr 29 '24 08:04 FelixMalfait

We should also:

  • Implement/reimplement this behavior: https://github.com/twentyhq/twenty/issues/2503
  • Include an "Add record" option in the column menu: CleanShot 2024-04-29 at 12 00 14@2x

Bonapara avatar Apr 29 '24 10:04 Bonapara

Should it look like this? If the button is meant to be there, where should the dropdown appear? at the end of the column where new opportunity is being created? or is it fine this way? Could you tell how should the ui/ux look like?

Or would have to add button on the upper right corner? But then how do we specify which column would be it adding to?

https://github.com/user-attachments/assets/2523ee5b-751b-47ed-aeb1-a0b68519cb7a

ehconitin avatar Aug 17 '24 16:08 ehconitin

@ehconitin thanks! The "+ New" should stay at the bottom where it was (with opportunity created at the bottom) What @Bonapara had in mind was to add in it the menu that appears when you click on a column's header.

We should also add it to the upper-right corner like on list-views yes ; v1 is to make it create it at the top in the column which is most on the left probably. We can always iterate from there

FelixMalfait avatar Aug 18 '24 09:08 FelixMalfait

Should I assign this to you @ehconitin? Assigning you but let me know if not!

FelixMalfait avatar Aug 18 '24 09:08 FelixMalfait

Opened PR 6649

Thanks

ehconitin avatar Aug 18 '24 16:08 ehconitin

Amazing thanks @ehconitin! I'll be mostly away from keyboard for the next 2 weeks but someone else will review :)

FelixMalfait avatar Aug 19 '24 08:08 FelixMalfait

Enjoy your time off @FelixMalfait! 🫡

ehconitin avatar Aug 19 '24 08:08 ehconitin

Amazing thanks a lot @ehconitin! @Bonapara would you mind re-recreating a separate issue for the "+" button on top-right? You probably had something designed/in mind already?

FelixMalfait avatar Aug 28 '24 15:08 FelixMalfait

Yes! -> https://github.com/twentyhq/twenty/issues/6783

Bonapara avatar Aug 29 '24 09:08 Bonapara

@lucasbordeau Thanks! :heart:

pombredanne avatar Aug 31 '24 21:08 pombredanne

Thanks @pombredanne for the great feedback always! @ehconitin deserves most of the credit here 😁

FelixMalfait avatar Sep 01 '24 19:09 FelixMalfait

@pombredanne You're welcome !

lucasbordeau avatar Sep 04 '24 20:09 lucasbordeau