twenty icon indicating copy to clipboard operation
twenty copied to clipboard

Add storybook tests on ObjectFilterDropdownOptionSelect

Open thomtrp opened this issue 1 year ago • 31 comments

Scope & Context

Follow-up on this PR: https://github.com/twentyhq/twenty/pull/3656 New components have been added without any storybook test.

Technical inputs

File paths are the following:

  • packages/twenty-front/src/modules/ui/navigation/menu-item/components/MenuItemSelectTag.tsx
  • packages/twenty-front/src/modules/object-record/object-filter-dropdown/components/ObjectFilterDropdownOptionSelect.tsx

thomtrp avatar Mar 05 '24 15:03 thomtrp

Hi @thomtrp I took a look the folders, none of the components in packages/twenty-front/src/modules/object-record/object-filter-dropdown/components have a story, ideally when we create a new component we should write the respective story too?

anoopw3bdev avatar Mar 07 '24 10:03 anoopw3bdev

I'm going to work on this issue.

ZichenMen avatar Apr 10 '24 17:04 ZichenMen

I will be working on this issue as well.

clrminded avatar Apr 13 '24 03:04 clrminded

Hello @thomtrp,

  • MenuItemSelectTag - already story exists for this component

  • ObjectFilterDropdownOptionSelect - related to object-filter-dropdown folder, there are no stories written in it.

  • So can you close this issue and create separate issue to write stories for object-filter-dropdown folder

BalanaguYashwanth avatar Aug 26 '24 14:08 BalanaguYashwanth

@BalanaguYashwanth Thanks for checking, I have renamed the issue

charlesBochet avatar Sep 14 '24 15:09 charlesBochet

/oss.gg 150

Bonapara avatar Oct 02 '24 07:10 Bonapara

Thanks for opening an issue! It's live on oss.gg!

oss-gg[bot] avatar Oct 02 '24 07:10 oss-gg[bot]

/assign

priyanshu-kun avatar Oct 10 '24 13:10 priyanshu-kun

Assigned to @priyanshu-kun! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

oss-gg[bot] avatar Oct 10 '24 13:10 oss-gg[bot]

/assign

pra2107tham avatar Oct 11 '24 11:10 pra2107tham

This issue is already assigned to another person. Please find more issues here.

oss-gg[bot] avatar Oct 11 '24 11:10 oss-gg[bot]

/assign

yashdarji30 avatar Oct 11 '24 14:10 yashdarji30

This issue is already assigned to another person. Please find more issues here.

oss-gg[bot] avatar Oct 11 '24 14:10 oss-gg[bot]

@priyanshu-kun, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

oss-gg[bot] avatar Oct 12 '24 01:10 oss-gg[bot]

/assign

sateshcharan avatar Oct 12 '24 13:10 sateshcharan

This issue is already assigned to another person. Please find more issues here.

oss-gg[bot] avatar Oct 12 '24 13:10 oss-gg[bot]

This issue is already assigned to another person. Please find more issues here.

oss-gg[bot] avatar Oct 12 '24 16:10 oss-gg[bot]

@priyanshu-kun, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

oss-gg[bot] avatar Oct 14 '24 01:10 oss-gg[bot]

/unassign

charlesBochet avatar Oct 14 '24 06:10 charlesBochet

Issue unassigned.

oss-gg[bot] avatar Oct 14 '24 06:10 oss-gg[bot]

/assign

rashap224 avatar Oct 14 '24 14:10 rashap224

Assigned to @rashap224! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

oss-gg[bot] avatar Oct 14 '24 14:10 oss-gg[bot]

Hi @thomtrp Can you explain a bit about this issue. I am curious to know and work on it.

rashap224 avatar Oct 14 '24 14:10 rashap224

@priyanshu-kun, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

oss-gg[bot] avatar Oct 16 '24 01:10 oss-gg[bot]

@rashap224, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

oss-gg[bot] avatar Oct 16 '24 02:10 oss-gg[bot]

/unassign

charlesBochet avatar Oct 17 '24 17:10 charlesBochet

Issue unassigned.

oss-gg[bot] avatar Oct 17 '24 17:10 oss-gg[bot]

Hey @charlesBochet, Can I work on this?

Khaan25 avatar Oct 18 '24 04:10 Khaan25

sure

charlesBochet avatar Oct 18 '24 07:10 charlesBochet

Hey @charlesBochet, I've created story and only imported the component to see but I'm getting this error? Do we've some providers to wrap around the story in decorators? image

Khaan25 avatar Oct 20 '24 08:10 Khaan25