twenty
twenty copied to clipboard
Add storybook tests on ObjectFilterDropdownOptionSelect
Scope & Context
Follow-up on this PR: https://github.com/twentyhq/twenty/pull/3656 New components have been added without any storybook test.
Technical inputs
File paths are the following:
- packages/twenty-front/src/modules/ui/navigation/menu-item/components/MenuItemSelectTag.tsx
- packages/twenty-front/src/modules/object-record/object-filter-dropdown/components/ObjectFilterDropdownOptionSelect.tsx
Hi @thomtrp I took a look the folders, none of the components in packages/twenty-front/src/modules/object-record/object-filter-dropdown/components have a story, ideally when we create a new component we should write the respective story too?
I'm going to work on this issue.
I will be working on this issue as well.
Hello @thomtrp,
-
MenuItemSelectTag - already story exists for this component
-
ObjectFilterDropdownOptionSelect - related to
object-filter-dropdownfolder, there are no stories written in it. -
So can you close this issue and create separate issue to
write stories for object-filter-dropdown folder
@BalanaguYashwanth Thanks for checking, I have renamed the issue
/oss.gg 150
Thanks for opening an issue! It's live on oss.gg!
/assign
Assigned to @priyanshu-kun! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀
/assign
This issue is already assigned to another person. Please find more issues here.
/assign
This issue is already assigned to another person. Please find more issues here.
@priyanshu-kun, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.
/assign
This issue is already assigned to another person. Please find more issues here.
This issue is already assigned to another person. Please find more issues here.
@priyanshu-kun, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.
/unassign
Issue unassigned.
/assign
Assigned to @rashap224! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀
Hi @thomtrp Can you explain a bit about this issue. I am curious to know and work on it.
@priyanshu-kun, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.
@rashap224, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.
/unassign
Issue unassigned.
Hey @charlesBochet, Can I work on this?
sure
Hey @charlesBochet, I've created story and only imported the component to see but I'm getting this error? Do we've some providers to wrap around the story in decorators?