twenty
twenty copied to clipboard
Update the Kanban column menu
Current behavior
There is only one button "Edit from settings" that links to the object page in Settings
Links to Object Settings:
Desired Behavior
There should be 3 buttons: 1- Edit (Should redirect to the field settings page instead of the object settings page) 2- Hide (Should hide the step) 3- Add Record (It should add a record in the column below)
1- Should link to the corresponding Select Field settings instead of Object Settings
Figma
https://www.figma.com/file/xt8O9mFeLl46C5InWwoMrN/Twenty?type=design&node-id=19118-196797&mode=design&t=ZRf0c7Ey66nuhFnZ-11
Hi @Bonapara I can work on this
Thanks @Kanav-Arora!
@Kanav-Arora do you think you can tackle this with previous feedback? Thanks š
Hi @FelixMalfait I'm bit unavailable for some days. If someone else wants, they can do it, i'll join in soon.
@Kanav-Arora I just unassigned you but tell me if you want to pick it up again. Thanks!
@Bonapara Add record should be fairly easy as it was already done in #6649 I had questions regarding hide button. How would user unhide the stage? presently user can hide/unhide fields
But this new hide/unhide would be on stages right?
Hi @ehconitin! It's related to https://github.com/twentyhq/twenty/issues/4356
Got it! Thanks šš»
@ehconitin see comment here for implementation details https://github.com/twentyhq/twenty/pull/4640#issuecomment-2036856758 ; not sure if you did any backend yet, this requires changing the data model
But since then I changed my mind. I think adding a JSONB is not a great practise, and there's a way to build something more generic as that notion of "grouping" we need for kanban could also be useful to listViews.
So instead now I would create a new object ViewGroup that would be very similar to ViewField in its implementation.
The backend is not there yet @ehconitin do you need assistance on the backend or you can take care of it too?
@FelixMalfait could you explain a bit more what you have in mind for ViewGroup from a product perspective and how you would use it for this case?
As a reminder this is our view database structure
@charlesBochet I would need some help with backend, just to get me started! Iām slowly getting the hang of it !
In a nutshell:
- View Group Object
- you'll need to create a view-group.workspace-entity.ts (similar to view-field). This will be the code representation of the standard object
- then new workspaces will have it (on sign up), when you seed workspaces too. For existing ones, you'll need to sync-metadata to get it
- View Group Object Record
- You'll need to add seed data for your new object (you can take inspiration on viewFIeld). Here are the case too tests: seed:dev and seed:demo
- you'll need to add prefill data for your new object for new workspaces. You can test it by signing up
- you'll need to add this data to existing workspaces, to do that please create a migrate-0.31 command. You also have example in the code
that should be it all the rest should be dynamically and automatically generated by the engine
From a product perspective what I meant is that it isn't just a kanban problem, groups could be useful to other types of views.
For example in Notion, it can be used on ListViews
It then becomes the exact same principles as for kanbans. The only difference is that we don't have auto-load but we have a "load more" button under each group if they are more than 20 records
https://www.figma.com/design/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=39994-147104&node-type=frame&t=ORiKleP9aYfoCt0X-11
https://github.com/user-attachments/assets/453313a5-0aaa-4f99-b02a-e736340dec10
Settings part ā https://www.figma.com/design/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=40011-268035&node-type=frame&t=vjg6Ofev4bkaijG1-11