twenty icon indicating copy to clipboard operation
twenty copied to clipboard

fix: rating type issues

Open magrinj opened this issue 1 year ago • 1 comments

This pull request addresses an issue related to the metadata type of the RATING field. It has been identified that the RATING field must comply with the GraphQL enum type naming convention, which stipulates adherence to the regular expression pattern ^[_A-Za-z][_0-9A-Za-z]+$. To resolve this, we have reformatted the rating values to align with this pattern, now utilizing the format RATING_.

Additionally, the front-end has been updated to ensure compatibility with this change.

magrinj avatar Jan 26 '24 11:01 magrinj

While testing, I've faced the following error: image

Exception Captured
  TypeError: Cannot read properties of undefined (reading 'map')
      at PostgresQueryRunner.createEnumTypeSql (/Users/charles/dev/twenty/twenty/src/driver/postgres/PostgresQueryRunner.ts:4265:20)
      at PostgresQueryRunner.addColumn (/Users/charles/dev/twenty/twenty/src/driver/postgres/PostgresQueryRunner.ts:986:37)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)
      at WorkspaceMigrationRunnerService.createColumn (/Users/charles/dev/twenty/twenty/packages/twenty-server/src/workspace/workspace-migration-runner/workspace-migration-runner.service.ts:230:5)
      at WorkspaceMigrationRunnerService.handleColumnChanges (/Users/charles/dev/twenty/twenty/packages/twenty-server/src/workspace/workspace-migration-runner/workspace-migration-runner.service.ts:172:11)
      at WorkspaceMigrationRunnerService.handleTableChanges (/Users/charles/dev/twenty/twenty/packages/twenty-server/src/workspace/workspace-migration-runner/workspace-migration-runner.service.ts:109:9)
      at WorkspaceMigrationRunnerService.executeMigrationFromPendingMigrations (/Users/charles/dev/twenty/twenty/packages/twenty-server/src/workspace/workspace-migration-runner/workspace-migration-runner.service.ts:72:7)
      at FieldMetadataService.createOne (/Users/charles/dev/twenty/twenty/packages/twenty-server/src/metadata/field-metadata/field-metadata.service.ts:94:5)
      at target (/Users/charles/dev/twenty/twenty/node_modules/@nestjs/core/helpers/external-context-creator.js:74:28)
      at Object.createOneField (/Users/charles/dev/twenty/twenty/node_modules/@nestjs/core/helpers/external-proxy.js:9:24)
Exception Captured
  TypeError: Cannot read properties of undefined (reading 'map')
      at PostgresQueryRunner.createEnumTypeSql (/Users/charles/dev/twenty/twenty/src/driver/postgres/PostgresQueryRunner.ts:4265:20)
      at PostgresQueryRunner.addColumn (/Users/charles/dev/twenty/twenty/src/driver/postgres/PostgresQueryRunner.ts:986:37)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)
      at WorkspaceMigrationRunnerService.createColumn (/Users/charles/dev/twenty/twenty/packages/twenty-server/src/workspace/workspace-migration-runner/workspace-migration-runner.service.ts:230:5)
      at WorkspaceMigrationRunnerService.handleColumnChanges (/Users/charles/dev/twenty/twenty/packages/twenty-server/src/workspace/workspace-migration-runner/workspace-migration-runner.service.ts:172:11)
      at WorkspaceMigrationRunnerService.handleTableChanges (/Users/charles/dev/twenty/twenty/packages/twenty-server/src/workspace/workspace-migration-runner/workspace-migration-runner.service.ts:109:9)
      at WorkspaceMigrationRunnerService.executeMigrationFromPendingMigrations (/Users/charles/dev/twenty/twenty/packages/twenty-server/src/workspace/workspace-migration-runner/workspace-migration-runner.service.ts:72:7)
      at FieldMetadataService.createOne (/Users/charles/dev/twenty/twenty/packages/twenty-server/src/metadata/field-metadata/field-metadata.service.ts:94:5)
      at target (/Users/charles/dev/twenty/twenty/node_modules/@nestjs/core/helpers/external-context-creator.js:74:28)
      at Object.createOneField (/Users/charles/dev/twenty/twenty/node_modules/@nestjs/core/helpers/external-proxy.js:9:24)

GraphQL payload: {"operationName":"CreateOneFieldMetadataItem","variables":{"input":{"field":{"description":null,"icon":"IconUsers","label":"Rating test2","name":"ratingTest2","objectMetadataId":"ba73ca61-52e2-4e89-9cfb-c20765ed508e","type":"RATING"}}},"query":"mutation CreateOneFieldMetadataItem($input: CreateOneFieldMetadataInput!) {\n createOneField(input: $input) {\n id\n type\n name\n label\n description\n icon\n isCustom\n isActive\n isNullable\n createdAt\n updatedAt\n defaultValue\n options\n __typename\n }\n}"}

charlesBochet avatar Jan 26 '24 15:01 charlesBochet

While testing, I've faced the following error...

I'll take a look on that !

magrinj avatar Jan 30 '24 07:01 magrinj

@charlesBochet I've rebased the PR and doesn't have the issue actually

magrinj avatar Jan 30 '24 08:01 magrinj