twenty icon indicating copy to clipboard operation
twenty copied to clipboard

Fix relation picker

Open FelixMalfait opened this issue 1 year ago • 6 comments

Just noticed the relation picker isn't properly displayed on Storybook. Probably something to fix on the component itself

https://storybook.twenty.com/?path=/story/ui-input-relationpicker-singleentityselect--with-selected-entity

Screenshot 2024-01-18 at 12 04 03

FelixMalfait avatar Jan 18 '24 11:01 FelixMalfait

@FelixMalfait I had checked this issue and in storybook it is breaking, do you find out any place in the application where it is breaking? because I could see it working correctly.

anoopw3bdev avatar Jan 25 '24 11:01 anoopw3bdev

@anoopw3bdev it seems to be working correctly in the app yes, not sure why it's breaking - I haven't investigated

FelixMalfait avatar Jan 25 '24 11:01 FelixMalfait

It seems to be breaking due to the height: 100% property of the styled component StyledDropdownMenuItemsExternalContainer in DropdownMenuItemsContainer component

anoopw3bdev avatar Jan 25 '24 12:01 anoopw3bdev

@anoopw3bdev feel free to raise a fix if you're confident in your solution! Thanks 🙏

FelixMalfait avatar Jan 25 '24 17:01 FelixMalfait

Sure @FelixMalfait will raise a fix soon

anoopw3bdev avatar Jan 26 '24 06:01 anoopw3bdev

FYI, I'm still on it @FelixMalfait, facing some issues with running the twenty app locally, requested some help from the team.

anoopw3bdev avatar Jan 29 '24 12:01 anoopw3bdev

@FelixMalfait this issue no more seems to exist. Please confirm.

Screenshot 2024-02-01 at 6 25 40 PM

anoopw3bdev avatar Feb 01 '24 12:02 anoopw3bdev

Yes seems like someone fixed it in the mean time!

FelixMalfait avatar Feb 01 '24 13:02 FelixMalfait