twenty icon indicating copy to clipboard operation
twenty copied to clipboard

Favicons are being re-rendered on hover

Open FelixMalfait opened this issue 1 year ago • 8 comments

Not sure how this would best be solved cleanly, but it's a bit annoying from a UI perspective.

https://github.com/twentyhq/twenty/assets/6399865/31ce34ac-1491-450b-bc99-57d445e6602f

FelixMalfait avatar Jan 17 '24 16:01 FelixMalfait

Is it that the favicon should remain visible even when hovering?

ijayhub avatar Jan 20 '24 09:01 ijayhub

I would like to work on it

ijayhub avatar Jan 20 '24 09:01 ijayhub

Hi @ijayhub as you can see hovering the components triggers a re-render of the image. We want to do something clean to avoid that. I don't think we should refetch the favicons on hover at - if there's been a 500 then we just accept it and live the placeholder icon as it is. Assigned you! Thanks

FelixMalfait avatar Jan 20 '24 12:01 FelixMalfait

Good morning, I won't be able to work on this repository at the moment. Can I extend it, please? or assign it to someone else? Thank you

ijayhub avatar Jan 30 '24 05:01 ijayhub

Sure! unassigned you

FelixMalfait avatar Jan 31 '24 12:01 FelixMalfait

Hi @FelixMalfait I would like to take this issue

essofyany avatar Feb 17 '24 01:02 essofyany

@essofyany sorry for the late reply - just assigned you! Thanks

FelixMalfait avatar Feb 19 '24 16:02 FelixMalfait

Here is the GitStart Ticket for this issue: https://clients.gitstart.com/twenty/5449/tickets/TWNTY-3523

gitstart-app[bot] avatar May 15 '24 07:05 gitstart-app[bot]