twenty icon indicating copy to clipboard operation
twenty copied to clipboard

fixed Object settings font weight fixes

Open abdul-irfan-k opened this issue 1 year ago • 1 comments

fix #3319 Screenshot from 2024-01-09 19-49-12

abdul-irfan-k avatar Jan 09 '24 14:01 abdul-irfan-k

CLA

Hello there and welcome to our project! By submitting your Pull Request, you acknowledge that you agree with the terms of our Contributor License Agreement. Although we don't have a dedicated legal counsel, having this kind of agreement can protect us from potential legal issues or patent trolls. Thank you for your understanding.

Generated by :no_entry_sign: dangerJS against 23326eb9661bf5c166a66c4d9f44fde5d419c460

github-actions[bot] avatar Jan 09 '24 14:01 github-actions[bot]

@Bonapara We use icon stroke for icons, we could lower the "sm" stroke size from 1.6 to 1.4 to match the Figma stroke size what do you think ?

lucasbordeau avatar Jan 10 '24 08:01 lucasbordeau

@lucasbordeau, when Charles and I implemented it, we observed that the font-weight of icons appeared lighter in Chrome compared to Figma. That's why it's 1.6 instead of 1.4) It would be great if the properties were consistent, ensuring that they render the same way but not sure it would work!

Also, in this specific case, the weight should be lighter than SM, (1.0 on Figma)

Bonapara avatar Jan 10 '24 09:01 Bonapara

can i change it

abdul-irfan-k avatar Jan 10 '24 12:01 abdul-irfan-k

@abdul-irfan-k I have checked with @Bonapara Let's only fix the Tag weight :)

charlesBochet avatar Jan 11 '24 11:01 charlesBochet